search

GoogleWebComponents / google-signin

Google Sign-in web component
https://elements.polymer-project.org/elements/google-signin
Other
279 stars 89 forks source link

Remove warnings and error when depending on google signin library #174

Closed viviennelee-work closed 4 years ago

viviennelee-work commented 4 years ago

When dependending on these libraries from our package, we get warnings like: WARNING - [JSC_HIDDEN_INTERFACE_PROPERTY] property _template already defined on interface Polymer_ElementMixin; use @override to override it _template: html`

Also get this error: ERROR - [JSC_BAD_JSDOC_ANNOTATION] Parse error. illegal use of unknown JSDoc tag "attribute"; ignoring it

This change is to add the recommended @override and remove the offending @attribute.