search

GoogleWebComponents / google-youtube

YouTube video playback web component
https://elements.polymer-project.org/elements/google-youtube
Other
131 stars 58 forks source link

wmode=opaque by default #60

Closed BLamy closed 8 years ago

BLamy commented 8 years ago

This web component should probably set wmode by default so that IE won't place videos above everything.

The way this element is now; If I place a google-youtube inside of a paper-scroll-header-panel the video will go over the paper-toolbar when scrolling on IE (Edge, and lower) which probably isn't desired behavior for most.

ebidel commented 8 years ago

@jeffposnick ?

jeffposnick commented 8 years ago

Just to clarify, <google-youtube wmode="opaque"> element accomplishes what you'd expect, correct?

In general, my philosophy with <google-youtube> has been to use the defaults of the underlying <iframe> embed.

Given the decreased relevance of Flash playback (though it's obviously still used for some browser/video combinations) and the fact there might be developers who, intentionally or not, depend on the existing default wmode setting, I'm inclined to leave the default as is.

BLamy commented 8 years ago

@jeffposnick That's exactly correct, <google-youtube wmode="opaque"> works as intended. Took me a little googling to arrive at that solution.

It's kind of a cross browser gotcha. Setting it to opaque would possibly effect current implementations, however, would ultimately lead to the element rendering more consistently in environments that might be overlooked by the developer.

jeffposnick commented 8 years ago

Given that the official <iframe> embedded YouTube player defaults to leaving it unset, I think that having <google-youtube> do the same thing would keep things consistent.

I'm sorry that the solution wasn't obvious, but it sounds like you do have a workaround now for your use case.