Gopal50 / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

Tri-State checkbox handling in repo browser #552

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Discussion is here:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=306391
8

Starts with:
Disclaimer: I attach patch, but it is only DRAFT. If it will be agreed to
apply, then I test it more heavily.

I try improve behavior of 'Choose items' dialog by:

1. When tree item inserted into tree, it inherit parent check state

I think it is logical - expand checked item and see all children checked.
Expand unchecked item and see all items unchecked

As side effect all items initially checked (inherit root check state).

2. Introduce pseudo tri-state behavior (but not look):

If user click unchecked item, then only this item checked (depth - 'Only
this item')
If user click checked item and all children unchecked - check whole subtree
If user click checked item and not all children unchecked - uncheck whole
subtree

This rule not concern when:

  * several items selected in tree.
it can confuse user when click can lead to different effects: some items
will be checked, some unchecked. check/uncheck will be applied recursevily
to all selected items and theirs children

 * item collapsed
it will confuse user when check will be reset only from second try without
other side effects.
also if item still not loaded, then we will not remember special
semi-checked mode.

Original issue reported on code.google.com by tortoisesvn on 6 Sep 2013 at 3:14

GoogleCodeExporter commented 8 years ago
Since this is something that bothers a lot of users apparently (search the 
mailing list...), I think I'll backport this to the stable branch...

Original comment by tortoisesvn on 6 Sep 2013 at 3:15

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r24738.

Original comment by tortoisesvn on 6 Sep 2013 at 3:18

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r24739.

Original comment by tortoisesvn on 6 Sep 2013 at 3:25