search

GopherML / bag

Bag of words as code
MIT License
85 stars 0 forks source link

Initial pull #1

Closed itsmontoya closed 3 months ago

itsmontoya commented 3 months ago

Initial pull request for Bag! Aiming for a fully usable model generator. Will work on compiled models and the bag-as-code features in future releases.

itsmontoya commented 3 months ago

I received some review notes from @chewxy

the algorithm looks correct I think there may be plenty of efficiency to be gained by hoising Vocabulary out of the loop process basically, have one pass to make Vacabulary first but what you have here? absolutely should work

I'm going to create an issue from the efficiency note and merge this PR as is.

Thank you to @chewxy and @BrandenWilliams for reviewing!