GopherML / bag

Bag of words as code
MIT License
86 stars 0 forks source link

Look into potential performance enhancement regarding vocabulary generation #2

Open itsmontoya opened 4 months ago

itsmontoya commented 4 months ago

I received some review notes from @chewxy

the algorithm looks correct I think there may be plenty of efficiency to be gained by hoising Vocabulary out of the loop process basically, have one pass to make Vacabulary first but what you have here? absolutely should work