Adjust naming to match ML best practices

GopherML / bag

Bag of words as code

MIT License

86 stars 0 forks source link

Adjust naming to match ML best practices #5

Closed itsmontoya closed 4 months ago

itsmontoya commented 4 months ago

I received a code review from @jbmuir:

I'm not sure the laplace smoothing equation is totally correct (missing smoothing parameter in the numerator). As a style note, you should be .gettingLogPriorProbability (rather than PriorProbability)

I was able to fix the laplace smoothing issue within https://github.com/itsmontoya/bag/pull/4. Will fix the naming recommendation soon!

itsmontoya commented 4 months ago

Fixed final requests within https://github.com/GopherML/bag/pull/6