search

GorNishanov / coroutines-ts

20 stars 2 forks source link

XX023: Clarify from_address's definition #6

Open brycelelbach opened 7 years ago

brycelelbach commented 7 years ago

[coroutine.handle.import.export] isn't totally clear what from_address does. I'd like to add a Returns: or Effects: paragraph that makes it clear what this does.

The Requires: paragraph should be a Preconditions: paragraph instead. (I made a separate issue for this, #7).

I'm glad to send a PR for these changes, but I'm not sure if they are strictly editorial. Let me know how you'd like me to proceed.

GorNishanov commented 7 years ago

Let's LEWG/LWG ponder on that.

The intent is that address() from_address() convert from a coroutine handle to a void* and back. Whatever is the best way to state it, I am all for it.

GorNishanov commented 7 years ago

Meaning, I will grab your PR and add them to the paper suggesting diffs to Coroutine TS in Toronto.

brycelelbach commented 7 years ago

Sounds good, I'll send a PR with suggested wording.