search

GordonLesti / Lesti_Fpc

Simple Magento Fullpagecache
https://gordonlesti.com/lesti-fpc-documentationversion-1-4-5/
Other
358 stars 158 forks source link

Cache the response content-type header #195

Closed GordonLesti closed 8 years ago

GordonLesti commented 8 years ago

Hello @kurtinge please review as this is build on your Cache the response content-type header.

kurtinge commented 8 years ago

Hi @GordonLesti

I think what you did here is a great solution. I really like the idea of the cacheitem object. That makes it easier to extend if there is needed to add new elements to the cache.

The only "downside" I can think of right now is that the serialization of the object is about 100 bytes larger than for an array serialization, but looking at the big picture that is proably nothing to worry about.

GordonLesti commented 8 years ago

Yes, I guess you are right. I will improve that tomorrow.

GordonLesti commented 8 years ago

@kurtinge better?

kurtinge commented 8 years ago

I think this looks very good.