search

GordonLesti / Lesti_Fpc

Simple Magento Fullpagecache
https://gordonlesti.com/lesti-fpc-documentationversion-1-4-5/
Other
358 stars 159 forks source link

Community Poll - not working #62

Open ADDISON74 opened 10 years ago

ADDISON74 commented 10 years ago

Magento CE 1.9.0.1, FPC::Lesti is caching Community Poll I guess because when I vote the side block remains unchanged, ready for another vote, but not showing any results.

I need a solution to skip caching for Community Poll side block. I can keep Polls hide for a while, but not too long. Thank you.

GordonLesti commented 10 years ago

Lesti_Fpc isn't Magento 1.9 ready at the moment. What means: caching Community Poll?

nhp commented 10 years ago

Did not know the poll is working at all. Try adding poll_vote_add to the refresh actions and add right.poll (or whatever you named the block, right.poll should be the standard name) to the lazy blocks. I have not tested it myself because our 1.9 shop has no poll enabled but the rest ist working fine with 1.9. Iirc all i had to do was to change a bit of backend configuration because at least in the rwd-theme that came with 1.9 some block-names have changed and some event names also. GordonLesti do you plan on supporting 1.9 (maybe create a branch so we can PR against it).

GordonLesti commented 10 years ago

@nhp I'm working at 1.9 and some more changes at the dev branch.

ADDISON74 commented 10 years ago

I tried Turpentine Varnish using latest Varnish v3 (v4 is not supported yet). v1.9 is working great, very fast, but I have issues with header block (after me I would split header in small parts) especially search box when instant search is used (no dropdown list) and Community Poll. Avoiding lots of unknown issues I came back to Lesti::FPC.

Mainly v1.9 is working great with Lesti::FPC. I managed boosting my requests 3.6 times which is great in my opinion. I found Community Poll not working.

@nhp: I did not change anything in default release. I will try adding it as you suggested.

@Gordon: I appreciate for this nice free extension which should be a "must have" for all Magento CE users. If you can update it to 1.9 it will be great. 1.9 brings a lot of issues resolved and better stability.

Nikita-S-Doroshenko commented 10 years ago

Lesti FPC is awesome! I'm too, looking forward for update for 1.9.

Thank you Gordon!

ADDISON74 commented 10 years ago

@nhp: I followed your advice and it is working. It should be included in the next FPC version.

Refresh Actions checkout_cart_add, checkout_cart_delete, checkout_cart_updatePost, catalog_product_compare_add, catalog_product_compare_clear, catalog_product_compare_remove, wishlist_index_add, wishlist_index_remove, wishlist_index_update, wishlist_index_allcart, wishlist_index_configure, checkout_onepage_success, poll_vote_add <-- ADD THIS LINE, DO NOT FORGET ABOUT comma LINE ABOVE --

Lazy Blacks top.links, cart_sidebar, catalog.compare.sidebar, wishlist_sidebar, welcome, right.poll <-- ADD THIS LINE, DO NOT FORGET ABOUT comma LINE ABOVE --

@Gordon: this options should be inserted line by line without comma. For a newbie like me I forgot to insert the comma and of course nothing happened. new line character should be used as line separator.

ADDISON74 commented 10 years ago

I would like to ask you for [Compare] button in side block "Compere Product" shouldn't it be add to [Refresh Actions] as catalog_product_compare_index?

Because Remove, Clear, Add are in Refresh Action already as

catalog_product_compare_add, catalog_product_compare_clear, catalog_product_compare_remove,

GordonLesti commented 10 years ago

@ADDISON74 but I just have to refresh if a item will be added, removed.

GordonLesti commented 10 years ago

@ADDISON74 I have add poll_vote_add to the refresh actions and right.poll. Thanks to you and @nhp

ADDISON74 commented 9 years ago

There is a big issue related to this change. Normally Community Poll is hidden after leaving that page or reloaded again with F5. After this change for pages visited before vote Community Poll still appears but with results. For new pages not visited before vote, Community Poll disappears which is a normal behavior.

I am looking for a solution.

GordonLesti commented 9 years ago

@ADDISON74 I will reopen the issue.

ADDISON74 commented 9 years ago

This problem appears in other FPC's (e.g. Nitrogento on its demo website here http://nitrostore.nitrogento.com/).

We need to find a solution to keep the poll working. Visitors like polls.

ADDISON74 commented 9 years ago

Hello Gordon, did you manage to solve the mystery for Community Pole?

GordonLesti commented 9 years ago

no, but PR's are welcome.

ADDISON74 commented 9 years ago

Any news? I installed Lesti::FPC on an old 1.7.0.2 and same issue appears. Really I don't understand why is this happening, when I identified correctly the dispatchevents and block name and added it in Lesti's FPC interface.

ADDISON74 commented 8 years ago

This is issue was present in Turpentine extension too. Here is how Nexcess programmers solved this issue, extending a class because they said is AJAX behind Community Pole. Gordon you can use the idea to fix your extension.

https://github.com/nexcess/magento-turpentine/blob/master/app/code/community/Nexcessnet/Turpentine/Block/Poll/ActivePoll.php