search

GordonSmith / vscode-ojs

VS Code extension for ObservableHQ notebooks
https://marketplace.visualstudio.com/items?itemName=GordonSmith.observable-js
MIT License
58 stars 5 forks source link

Clarify OJS settings and review Preview errors #28

Closed RandomFractals closed 2 years ago

RandomFractals commented 3 years ago

I noticed that you have a setting to show runtime values: https://github.com/GordonSmith/vscode-ojs#settings

I created standard .vscode/settings.json in my OJS notebooks project workspace.

Questions:

  1. Does that setting show cell runtime values for the cells that are not markup or viewof?
  2. Should I see them in a notebook, in vscode debug console, or dev tools?
  3. Should I set that setting in your custom config file per error below?

Please review other errors.

image

Thanks!

GordonSmith commented 3 years ago

1+2 - It doesn't work that well in VS Code but should display all the runtime values in the "Problems" tab as "Info". You can see what it looks like in the web version here: https://raw.githack.com/hpcc-systems/Visualization/trunk/demos/storyboard/index.html?Five-Minute%20Introduction%20(.omd) (also turning on off the debug option will show the cell values inline). image

  1. The ojs config file is simply missing from the package and as it happens has already been fixed in master (its part of the ojs syntax highlighting) I don't think the Buffer error is mine?
RandomFractals commented 3 years ago

great. Thanks for those clarifications.

yeah, I am not sure why I get that buffer error. it's def. not yours.

btw, I really like that filled cell promises table view. I will double check if it shows up in vscode as you describe. Maybe expand on it a bit in your setting doc section.

RandomFractals commented 2 years ago

@GordonSmith not sure if this is still relevant after your recent updates and addition of new OJS notebook kernel.

Feel free to close it, and many thanks for enabling Observable notebooks running in VSCode IDE with this excellent extension!