search

Gornova / MarteEngine

MarteEngine is a Java Engine for videogames
http://randomtower.blogspot.com
Other
74 stars 20 forks source link

propagate better coding style? #33

Open thaaks opened 13 years ago

thaaks commented 13 years ago

Not 100% sure about this one and sorry for bringing this issue back. But the last days I thought it would be better to remove the public instance variables and make them private or protected and provide standard getter and setter methods. Though I do see the advantage of simply saying "myEntity.x = 50;" it is still bad coding style. What is your opinion here?

Gornova commented 13 years ago

lack of automatic get or set in Java is a problem for me.. we can address it using something like project lombdok (http://projectlombok.org/), but we can force marteengine to use it?

I think is better to move this discussion to 0.4 or 0.5 version of MarteEngine, because we need to work a lot before have something stable

thaaks commented 13 years ago

Never heard about lombok but that's pretty cool!

With this project at hands I agree: let's move the issue (once more) to 0.4 or 0.5 and think about integrating lombok usage into Marte.

Nice find, Gornova!

Gornova commented 13 years ago

ok, moved to 0.4