Morning Session Peer-to-Peer review

Goruchie / Awesome-books-with-ES6

A bookshelf management app allows users to add, remove books and display a list with your favorite book selection. Built with JavaScript, HTML and CSS. Packages used: Luxon.

5 stars 1 forks source link

Morning Session Peer-to-Peer review #2

Open rmrmrmr opened 2 years ago

rmrmrmr commented 2 years ago

Your project looks great, congratulations! 🎉 Consider changing the following things to make your code even cleaner.

https://github.com/Goruchie/Awesome-books-with-ES6/blob/2232825e4a3d6f63de3820aece1c7c0f2aa42e91/index.html#L25

Deleting blank lines such as this one on line 25 would make your file smaller

MattGomb commented 2 years ago

Please kindly consider changing the luxon.js file to the condensed version that is suggested in the exercise. Otherwise the code looks clean and organized 👍

sonyco-4u commented 2 years ago

Great project, just try and remove some of the commented codes you are not using again. Happy Coding!