add user defined buttons, fixing #28

GorvGoyl / Shortcut-Menu-Bar-VSCode-Extension

Add handy buttons like beautify, show opened files, save, toggle terminal, etc to the editor menu bar in VSCode. You can also create your own buttons with custom commands. VSCode Marketplace link: https://marketplace.visualstudio.com/items?itemName=jerrygoyal.shortcut-menu-bar

https://marketplace.visualstudio.com/items?itemName=jerrygoyal.shortcut-menu-bar

GNU General Public License v3.0

221 stars 44 forks source link

add user defined buttons, fixing #28 #43

Closed GitMensch closed 3 years ago

GitMensch commented 3 years ago

icons made by Freepik https://www.freepik.com (color adjustment and formatting done manually)
new settings ShortcutMenuBar.userButton01Command to ShortcutMenuBar.userButton10Command: icons only shown if command is defined; with included keyboard bindings [CTRL]+[ALT]+1,2...,9,0
command execution (including sequences and parameters) and resolve of variables based on https://github.com/ppatotski/vscode-commandbar

Altogether: fixes #28

GitMensch commented 3 years ago

Works quite well for me, including command arguments and Parts that could be added later:

config caching: (all) settings are currently read on command execution and the one that is relevant is then used - one could define an object array for each of the ten buttons and store the commands in there; then create the objects on startup and only if the extension is called because of the configuration changed setup the content again
additionally store boolean attributes for "active yes/no": "is setup" and from an additional parse of the content "needs active workspace", "needs active Editor" and use this for showing/execute + hide
automated tests (not sure how those would have to be setup)
adding to the resolved variables, which can be completely removed if https://github.com/microsoft/vscode/issues/2809 is solved somedayTM

I may work on the first two items later, but I'd prefer a release with the buttons to be available beforehand.

GorvGoyl commented 3 years ago

Thank you. I'll sit this weekend to thoroughly review and test this PR. I noticed that you used custom svg icons for user-defined commands. Could vscode built-in icons be used for this? that way users will have wide varieties of icons to choose from. https://code.visualstudio.com/api/references/icons-in-labels

once again, thank you for putting efforts in this open-source project.

GitMensch commented 3 years ago

Could vscode built-in icons be used for this?

That's what I would have preferred in the first place... I know those icons can be used in different places and according to intellisense they can also be used in the command icons - but so far thie command icons are completely hard-wired in package.json, not sure if/how this can be adjusted via extension settings (we'd need a default in any case).

GorvGoyl commented 3 years ago

Just tested and it seems to be working fine. Kudos to the numbered icons and its corresponding hotkeys. Amazing work!!

GitMensch commented 3 years ago

Kudos to the numbered icons and its corresponding hotkeys. Amazing work!!

Thanks! Actually that was my second real work with TS, so that's encouraging for going on.

I guess #28 can now be closed and, possibly together with tackling #36, a new version be tagged and released?

GorvGoyl commented 3 years ago

Will release new version on both marketplaces and close dependent issues this week