GorvGoyl / Shortcut-Menu-Bar-VSCode-Extension

Add handy buttons like beautify, show opened files, save, toggle terminal, etc to the editor menu bar in VSCode. You can also create your own buttons with custom commands. VSCode Marketplace link: https://marketplace.visualstudio.com/items?itemName=jerrygoyal.shortcut-menu-bar
https://marketplace.visualstudio.com/items?itemName=jerrygoyal.shortcut-menu-bar
GNU General Public License v3.0
221 stars 44 forks source link

use of codicon icons where possible #71

Open GitMensch opened 2 years ago

GitMensch commented 2 years ago

This is "kind of" a draft. The main reason is that some symbols don't have an exact or "normal" matching icon, so I've looked up some possible alternatives to look at - and in the end the screenshots should be adjusted before a release can be done.

Reasons why those icons are preferable to the use of own svg files include:

Note: I'm totally aware that when this extension started there was no codicon option to use. But nowadays those code icons are available in even old installations of vscode so I think it is better to use them.

GitMensch commented 2 years ago

kindly requesting review from @GorvGoyl

GorvGoyl commented 2 years ago

Thanks, @GitMensch I'm all in for built-in vscode icons. I hope all new icons look similar to the existing ones. Could you also mention the use of built-in icons in help.md (### Adding new buttons) file so that it's easier for new contributors. Once the PR is merged I'll create a new release.