Goscord / goscord

A Discord API wrapper written in Golang.
https://goscord.dev
MIT License
72 stars 15 forks source link

Add voice receiving support #9

Open szerookii opened 1 year ago

MrWong99 commented 2 months ago

I would really much like (and need) thatπŸ‘πŸ»

I would be willing to try implementing this feature. Would that be okay or is someone already working on this?

Do you anticipate any major hurdles that one must tackle to add this feature? So far I just got the sending part to work, which was already a hassle for me as I am bad at audio de-/encoding...

szerookii commented 2 months ago

Hello, we already have audio receiving done on the #8 issue & feature/voice branch. You can still make a pull-request we can see if we can improve our implementation. Otherwise, no one is planning to do the reception at the moment, if you want to do a pull-request, it's welcome. πŸ‘€

MrWong99 commented 2 months ago

Wait is there a typo or do you actually mean receiving is already done in the branch?

If so: how would I get my hands at some of that audio data send by others?

If Not I can give it my best shot if it is not yet implemented. But I already saw that the Discord Voice Docs are a bit sparse when it comes to receiving. I can still lurk in other client implementations though πŸ˜†

szerookii commented 2 months ago

Wait is there a typo or do you actually mean receiving is already done in the branch?

If so: how would I get my hands at some of that audio data send by others?

If Not I can give it my best shot if it is not yet implemented. But I already saw that the Discord Voice Docs are a bit sparse when it comes to receiving. I can still lurk in other client implementations though πŸ˜†

Yep, sending. Huge typo lol

MrWong99 commented 2 months ago

I will devote some free time to look into the matter then.

And btw really nice library already! I was worried I needed to do the UDP package management or audio encryption myself but turns out: just encoding correctly and calling connection.Write() a bunch of times is enough 😁