GoshPosh / grafana-meta-queries

Grafana plugin for calculating time period metrics like week over week, month over month and year over year etc.
Apache License 2.0
284 stars 71 forks source link

Not working on 8.3.1 #139

Closed yggdrasil-tynor closed 2 years ago

yggdrasil-tynor commented 2 years ago

metaqueries doesn't work on Grafana 8.3.1 even when adding: allow_loading_unsigned_plugins = grafana-meta-queries. Nothing in the logs.

acederlund commented 2 years ago

I have the same issue, this is from our log file: lvl=warn msg="Skipping loading plugin due to problem with signature" logger=plugin.loader pluginID=goshposh-metaqueries-datasource status=unsigned

I did the same with "allow_loading_unsigned_plugins", so I guess it is signed, but there is a problem with the signature.

yggdrasil-tynor commented 2 years ago

@acederlund Strange, that it works when downgrading to 8.2.2. So something must have changed in the grafana upstream?

jhuebner79 commented 2 years ago

This project is dead, isn't it?

yggdrasil-tynor commented 2 years ago

Works fine with grafana 8.2.2 :)

jhuebner79 commented 2 years ago

That doesn't help much - we're not going to downgrade, so: not a real solution :)

Antartic0 commented 2 years ago

Any update? I was able to make grafana accept the unsigned plugin but it does not work:

lvl=info msg="Plugin registered" logger=plugin.manager pluginId=goshposh-metaqueries-datasource lvl=warn msg="Permitting unsigned plugin. This is not recommended" logger=plugin.signature.validator pluginID=goshposh-metaqueries-datasource pluginDir=/var/lib/grafana/plugins/goshposh-metaqueries-datasource

But the plugin is not working with this error: MetaQueries: Datasource [object Object] was not found

yggdrasil-tynor commented 2 years ago

It works with grafana <= 8.2.2. Something upstream broke the integration.

Ook3000 commented 2 years ago

It works with grafana <= 8.2.2. Something upstream broke the integration.

But will it be fixed to work afain in Releases > 8.2.2?

yggdrasil-tynor commented 2 years ago

It works with grafana <= 8.2.2. Something upstream broke the integration.

But will it be fixed to work afain in Releases > 8.2.2?

If somebody submits a PR :)

geryepes commented 2 years ago

@yggdrasil-tynor This PR https://github.com/GoshPosh/grafana-meta-queries/pull/141 can help you

bene86 commented 2 years ago

I tried the fix, but for me it is not properly working. I have to say I'm not an expert in Grafana. I use 8.3.2. I never had meta-queries propoerly working, I would like to have it for the timeshift functionality. I tried to set it up according to the docs. Before the fix, as soon as I added any MetaQueries datasource to my panel, it showed only "No data". After the fix, I can add a MetaQueries as second datasource (B) and with "arithmetic" I still see the original data but not the newly calculated data. With "movingAverage" and "TimeShift" I get again No data. Any ideas, what could be wrong?

Gauravshah commented 2 years ago

@bene86 can you send a screenshot of your dashbaord settings, very likely your panel datasource is not set to metaqueires

bene86 commented 2 years ago

Attached are two screenshots, one for "Arithmetic" one for "Timeshift" (which is what I want) Original data comes from an influxdb datasource

image image

bene86 commented 2 years ago

any usefull hint on the queries? did I set some wrong settings?

Gauravshah commented 2 years ago

You need to add Pac or sdf in the metric text box

On Fri, 4 Feb 2022 at 3:25 AM, bene86 @.***> wrote:

any usefull hint on the queries? did I set some wrong settings?

— Reply to this email directly, view it on GitHub https://github.com/GoshPosh/grafana-meta-queries/issues/139#issuecomment-1029438045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXQD6YODWPYFGZNMEGJIDUZL2VXANCNFSM5JT3I56A . You are receiving this because you commented.Message ID: @.***>

bene86 commented 2 years ago

Unfortunately, doesn't help. There is not metric text box for the Arithmetic type and if I type either "Pac" or "sdf" for the TimeShift type, it does not change at all: image

appcoders commented 2 years ago

Same here on TimeShift: runRequest.ts:146 runRequest.catchError TypeError: Cannot read properties of undefined (reading '0') at filter_datapoints (datasource.js:384:56) at eval (datasource.js:145:27)

yggdrasil-tynor commented 2 years ago

Seems this was merged in: https://github.com/GoshPosh/grafana-meta-queries/pull/128

Now we just need a new release and push to grafana plugins lib :)

ShilpaSivanesan commented 2 years ago

Fix for the issue https://github.com/GoshPosh/grafana-meta-queries/pull/141