search

GoshPosh / grafana-meta-queries

Grafana plugin for calculating time period metrics like week over week, month over month and year over year etc.
Apache License 2.0
284 stars 71 forks source link

fix: support grafana 8.3.x #141

Closed geryepes closed 2 years ago

geryepes commented 2 years ago

Upstream changes related to this PR https://github.com/grafana/grafana/commit/7319efe0779d97c8dac5b0e6d9a3749b177c45a0

geryepes commented 2 years ago

Resolves #139

yggdrasil-tynor commented 2 years ago

@geryepes For me it looks good. However it would be better for a regular contributor to make the review, as i haven't worked on grafana plugins.

Nice work by the way :)

vicioussn commented 2 years ago

Anyone? Please merge it.

Gauravshah commented 2 years ago

I can look into after 7 Days. On PTO

On Thu, 3 Feb 2022 at 11:32 PM, vicioussn @.***> wrote:

Anyone? Please merge it.

— Reply to this email directly, view it on GitHub https://github.com/GoshPosh/grafana-meta-queries/pull/141#issuecomment-1029256145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXQD33I7RTQT233TZRWLTUZK7MNANCNFSM5M6K5MNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yggdrasil-tynor commented 2 years ago

@Gauravshah would you be happy to review it? :-)

ryanpxyz commented 2 years ago

Hello,

... a quick turnaround on this would be very welcomed!

Thanks,

Phil.

ryanpxyz commented 2 years ago

Good morning,

Is there a status update? Are there plans to release a 0.0.6?

ShilpaSivanesan commented 2 years ago

@ShilpaSivanesan can we merge this ?

Sure, will validate and merge

yggdrasil-tynor commented 2 years ago

@Gauravshah / @ShilpaSivanesan sorry to bump you guys. But can this please be merged, so we can use this great plugin with grafana 8.4.0 👍

ryanpxyz commented 2 years ago

Good morning,

Is there a status update? Are there plans to release a 0.0.6?

ShilpaSivanesan commented 2 years ago

Thanks for your contribution @geryepes . Really appreciate it.