search

GoshPosh / grafana-meta-queries

Grafana plugin for calculating time period metrics like week over week, month over month and year over year etc.
Apache License 2.0
284 stars 71 forks source link

MetaQueriesDatasource.query infinite loop in grafana 6.3 #67

Closed justinvdm closed 5 years ago

justinvdm commented 5 years ago

MetaQueriesDatasource appears to rely on the name property being assigned in order to tell whether it is dealing with itself, or with a different data source.

Since 6.3 however, grafana seems to no longer assign name.

As a result, this logic branch is never reached, and the MetaQueriesDatasource instance ends up calling .query on itself indefinitely.

Gauravshah commented 5 years ago

duplicate of https://github.com/GoshPosh/grafana-meta-queries/issues/56

justinvdm commented 5 years ago

Woops, sorry for missing this, and thank you for the quick reply.

Gauravshah commented 5 years ago

Thank for finding out the details. I am unable to load the grafana diff due to timeout. Can you point to the commit that changed this behaviour ? It doesn't seem documented

justinvdm commented 5 years ago

Sure :) It was 1d7bb2a.

Gauravshah commented 5 years ago

thank you @justinvdm