search

GotelliLab / EcoSimR

Repository for EcoSimR, by Gotelli, N.J. , Hart E. M. and A.M. Ellison. 2014. EcoSimR 0.1.0
http://ecosimr.org
Other
29 stars 10 forks source link

Improved C-score and related metrics. #43

Closed ngotelli closed 9 years ago

ngotelli commented 9 years ago

We should definitely implement @davharris code for calculating the c_score, but restore line 369, which is the error check for empty rows.

Once this is done we should then modify the code for c_score.skew and c_score.var so that they call c_score. The error check needs to live only in c_score, not in these other functions.

@emhart how do I pull in @davharris fork in GitHub to get the new function?

davharris commented 9 years ago

My pull request is at #31. I think there will be a button that says "merge" to bring it in, if you decide to do so.

emhart commented 9 years ago

Successfully merged @davharris pr

ngotelli commented 9 years ago

Thank you @davharris and @emhart !