GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
732 stars 209 forks source link

Allow string CA path values for gitlab.verify_ssl #1015

Closed ahills closed 8 months ago

ahills commented 8 months ago

In bugwarrior.services.gitlab.GitlabClient._fetch(), the verify_ssl configuration value is given as the requests verify parameter, which can either be a boolean or a path to a CA certificate bundle:

https://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification

Simply extending the configuration type to include bugwarrior.config.ExpandedPath allows users to use non-public certificate authorities without disabling TLS verification entirely. This is preferable to setting the REQUESTS_CA_BUNDLE environment variable, which may interfere with other services using different certificate authorities.