search

GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
732 stars 209 forks source link

support for python 3.12 #1019

Closed NeilHanlon closed 6 months ago

NeilHanlon commented 7 months ago

python3.12 removed readfp(), recommended to use read_file() instead

NeilHanlon commented 7 months ago

Note: the if condition is to support python 2.X... not sure if that is necessary.

ryneeverett commented 7 months ago

Thanks. We've already dropped support for python-2. Please remove the if-condition (which should fix CI since you forgot to import sys) and, if you wouldn't mind, add the later python versions to .github/workflows/bugwarrior.yml. Note that the python-versions are listed two different places in the file. (I'm sure there's a smarter way to avoid that duplication but :shrug:.)

NeilHanlon commented 7 months ago

Absolutely, I can do that.

Would you like me to add all the versions between 3.9 (latest in the github action config) and 3.12, or just append 3.12 to the list?

ryneeverett commented 7 months ago

If you could add all the versions from 3.9 through 3.12 that would be great.

ryneeverett commented 7 months ago

Looking at the CI failure, it seems that yaml interprets 3.10 as a float and converts it to 3.1. I think it would be fixed by just putting "3.10" in quotes.

NeilHanlon commented 6 months ago

thanks for that - apologies that this fell off my radar

ryneeverett commented 6 months ago

No problem, it happens. I let this fall off my radar too since the repository owner opened a rival pull request and I wanted to give him a chance to get involved if he was interested.

ralphbean commented 6 months ago

Sorry for competing! Thanks for resolving @ryneeverett.