search

GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
736 stars 209 forks source link

Be more specific in matching NoOptionError in config parser #785

Closed djmitche closed 3 years ago

djmitche commented 3 years ago

In Python 3, ConfigParser is more exacting about the syntax it allows, and in particular it disallows bare % characters. This causes an error for URLs containing such characters, but the bare except just treated this error as a missing configuration and did not show it to the user.

djmitche commented 3 years ago

(This omitted the bugzilla.query_url parameter for me, which led to Bugzilla happily syncing EVERY BUGZILLA BUG I HAVE COMMENTED ON into taskwarrior. Luckily I caught this before it created more than a few dozen bugs)

djmitche commented 3 years ago

I'll fix the tests shortly.

djmitche commented 3 years ago

y u no run, travis?

ryneeverett commented 3 years ago

Seems like travis has massively decreased capacity and it frequently takes hour(s) to get allocated runners. This was my initial motivation for #774.

ryneeverett commented 3 years ago

FYI, I re-ran Travis and there are failing tests.

djmitche commented 3 years ago

Oh, thanks for the heads-up!

djmitche commented 3 years ago

Ok, should be good now. I'll keep the tab open and check the results.

ryneeverett commented 3 years ago

@djmitche Did you forget to push?

Edit: I see you pushed to the branch on your remote but this PR is on the branch on ralphbean's remote.

djmitche commented 3 years ago

I really am not new to GitHub :(

djmitche commented 3 years ago

woo, now it's green :)