search

GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
734 stars 209 forks source link

megaplan is not py3 compatible #829

Closed djmitche closed 3 years ago

djmitche commented 3 years ago 
funk ~/p/bugwarrior [issue828*] $ python setup.py test
running test                                             
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info                                                                                                                                                                                                                    
writing bugwarrior.egg-info/PKG-INFO                                                                                                                                                                                                
writing dependency_links to bugwarrior.egg-info/dependency_links.txt                                                                                                                                                                
writing entry points to bugwarrior.egg-info/entry_points.txt   
writing requirements to bugwarrior.egg-info/requires.txt                                                          
writing top-level names to bugwarrior.egg-info/top_level.txt
reading manifest file 'bugwarrior.egg-info/SOURCES.txt' 
reading manifest template 'MANIFEST.in'                                                                           
warning: no files found matching '*' under directory 'docs' 
warning: no previously-included files matching '__pycache__' found anywhere in distribution
writing manifest file 'bugwarrior.egg-info/SOURCES.txt'                                                           
running build_ext                     
Traceback (most recent call last):                                                                                
  File "setup.py", line 10, in <module>             
    setup(name='bugwarrior',                                                                                      
  File "/home/dustin/p/bugwarrior/sandbox/lib/python3.8/site-packages/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)                                                                          
  File "/usr/lib/python3.8/distutils/core.py", line 148, in setup   
    dist.run_commands()                                                                                           
  File "/usr/lib/python3.8/distutils/dist.py", line 966, in run_commands                           
    self.run_command(cmd)                                                                                         
  File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command                            
    cmd_obj.run()                           
  File "/home/dustin/p/bugwarrior/sandbox/lib/python3.8/site-packages/setuptools/command/test.py", line 237, in run
    self.run_tests()                                                                                              
  File "/home/dustin/p/bugwarrior/sandbox/lib/python3.8/site-packages/setuptools/command/test.py", line 255, in run_tests
    test = unittest.main(                                                                                         
  File "/usr/lib/python3.8/unittest/main.py", line 100, in __init__              
    self.parseArgs(argv)                                                                                          
  File "/usr/lib/python3.8/unittest/main.py", line 124, in parseArgs
    self._do_discovery(argv[2:])          
  File "/usr/lib/python3.8/unittest/main.py", line 244, in _do_discovery
    self.createTests(from_discovery=True, Loader=Loader)                                                          
  File "/usr/lib/python3.8/unittest/main.py", line 154, in createTests
    self.test = loader.discover(self.start, self.pattern, self.top)
  File "/usr/lib/python3.8/unittest/loader.py", line 349, in discover
    tests = list(self._find_tests(start_dir, pattern))                                                            
  File "/usr/lib/python3.8/unittest/loader.py", line 405, in _find_tests
    tests, should_recurse = self._find_test_path(                                                                 
  File "/usr/lib/python3.8/unittest/loader.py", line 483, in _find_test_path        
    tests = self.loadTestsFromModule(package, pattern=pattern)
  File "/home/dustin/p/bugwarrior/sandbox/lib/python3.8/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/usr/lib/python3.8/unittest/loader.py", line 191, in loadTestsFromName
    return self.loadTestsFromModule(obj)
  File "/home/dustin/p/bugwarrior/sandbox/lib/python3.8/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/usr/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/home/dustin/p/bugwarrior/bugwarrior/services/mplan.py", line 3, in <module>
    import megaplan
  File "/home/dustin/p/bugwarrior/.eggs/megaplan-1.4-py3.8.egg/megaplan/__init__.py", line 184
    except urllib2.HTTPError, e:
                            ^
SyntaxError: invalid syntax

I see a note about this in tests/test_megaplan.py, but it seems that's not enough -- bugwarrior.services.mplan is still being imported.

djmitche commented 3 years ago

Ah, this doesn't work with python setup.py test, because that doesn't use pytest and thus doesn't skip these tests. Let's fix this as part of #831.