search

GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
734 stars 209 forks source link

Pydantic #849

Closed ryneeverett closed 2 years ago

ryneeverett commented 2 years ago

See commit messages for motivation, etc.

ryneeverett commented 2 years ago

Thanks for having a look! I didn't expect anyone to do a thorough line-by-line review but it's nice to have a sanity check on such a large change before I beta test it on develop users.

Good question about the service schemas. The pydantic usage is by-the-book but the potential gotcha is that the schemas receive data that is still serialized from configparser. The only practical implication of this so far is that lists need need to be annotated with the custom field I've called ConfigList rather than simply list. Also the prefix used in configparser (e.g. github in github.login) needs to be passed to the constructor.

Since there is currently no documentation on contributing a service I'd prefer to leave that for a separate PR and have opened #855 to track it.

djmitche commented 2 years ago

Sounds good!