fmauch
commented
2 years ago Could you add a brief explanatory comment to each of these similar to those in the except OSError blocks? Something like "ConnectionError inherits from OSError and the service should fail without internet."
done
With query-based fetching it is possible to end up only in paths that catch connection errors. While catching OSErrors there might be a valid strategy given the points documented, this also catches failed connection attempts, as ConnectionRefusedError inherits from OSError.
Without this, it is possible that tasks get closed when connection to a gitlab instance cannot be established (Though internet connection is available, e.g. the gitlab instance is behind a non-connected VPN.).