search

GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
732 stars 209 forks source link

Adding Jitamin support #931

Closed gumulka closed 1 year ago

gumulka commented 2 years ago

I'm not sure, if this should be integrated upstream, as Jitamin is quite old, unmaintained and has no API, so this Plugin relies on web-scraping to get the needed information.

But it is the task-management solution my employer uses, and I use taskwarrior, so I wrote this.

gumulka commented 2 years ago

Hey, I "moved" the Jitamin logic to a new class. Will move the new class to a new project later on, but just wanted some feedback if that is what you had in mind.

Will add tests later this week.

ryneeverett commented 2 years ago

Hey, I "moved" the Jitamin logic to a new class. Will move the new class to a new project later on, but just wanted some feedback if that is what you had in mind.

Yes, the way the client class abstracts away the fetching/parsing from the service class is exactly what I had in mind.

I understand why you added the lazy Task class but I think it's somewhat confusing given the conceptual overlap with the Issue class. We don't have anything like this in any other bugwarrior service so there's no precedent, but I think the terminology might match up better if Task was renamed Record since that aligns with the fact that it represents remote data prior to the conversion into local taskwarrior data (akin to Issue.record). What do you think?

gumulka commented 1 year ago

The week after I created the pull request. My employer decided to ditch Jitamin and move to Jira. Since this is now a permanent decision and I won't be using this anymore and will not be able to fix any bugs, I'm closing this merge request.