search

GothenburgBitFactory / bugwarrior

Pull github, bitbucket, and trac issues into taskwarrior
http://pypi.python.org/pypi/bugwarrior
GNU General Public License v3.0
732 stars 209 forks source link

feat: macOS applescript notifications #948

Closed nekowinston closed 1 year ago

nekowinston commented 2 years ago

Would close #875. pytest failed for me locally, even before adding the feature, unsure why, exactly.

ryneeverett commented 1 year ago

We should add a deprecation warning to growlnotify before closing #875. However, that doesn't necessarily need to be done in this pull request.

nekowinston commented 1 year ago

Thank you for the review comments, I'll update the PR accordingly.

ryneeverett commented 1 year ago

@srl295 I don't have a mac to test this on. Can you test it out?

(Note that I will eventually merge this even if nobody tests it.)

nekowinston commented 1 year ago

Here's a screenshot of the notifications for the current implementation, after the reviews. bugwarrior-applescript

ryneeverett commented 1 year ago

Thank you both for your work on this!