search

GothenburgBitFactory / holidata

Holidata is the core of holidata.net, a no-nonsense, ad-free provider of international holiday data.
https://holidata.net
MIT License
43 stars 11 forks source link

Error in locale en-US, year 2024: Day after Thanksgiving #102

Closed RogueScholar closed 1 month ago

RogueScholar commented 4 months ago

In the en-US output for this year (2024), the "Day after Thanksgiving" holiday appears to have lost a week in its calculated value, such that it is reported as occurring on the Friday before Thanksgiving (six days prior) rather than the Friday after Thanksgiving (one day in advance).

Relevant contents of the file at time of reporting (click to expand) ```json {"locale":"en-US","region":"","date":"2024-11-22","description":"Day after Thanksgiving","type":"NV","notes":""} {"locale":"en-US","region":"","date":"2024-11-28","description":"Thanksgiving Day","type":"NV","notes":""} ```

The correct date for the Day after Thanksgiving in the locale en-US in the year 2024 is: 2024-11-29

Furthermore, no data is published on the site for the upcoming calendar year, 2025. It would be useful were it made so.

lauft commented 1 month ago

Thanks for spotting this error. This also affects years 2013 and 2019 where the 4. Friday is not after the 4. Thursday.