search

GothenburgBitFactory / holidata

Holidata is the core of holidata.net, a no-nonsense, ad-free provider of international holiday data.
https://holidata.net
MIT License
43 stars 11 forks source link

Some updates for the es-ES locale #58

Closed vice closed 3 years ago

vice commented 4 years ago

More official names and removed 'Noche Vieja' and 'Noche Buena' that are not official.

vice commented 4 years ago

WIP: More to come

vice commented 4 years ago

All those are regional holidays for the whole region. No local holidays, as those are too many. 2 days by locality. Maybe I will add some notes for big cities. For example Corpus Cristi (60 days after Eastern) Comunidad de Castilla y León regional holiday is also a local holiday for Seville and Granada cities.

I think this will complete the first series of patches. Variable Monday holidays will go in another batch.

vice commented 4 years ago

I need to check two more days that I forgot due to them being on Sunday this year (2020).

vice commented 3 years ago

Can you tell me how holidays in Spain are handled when they occur on a sunday and get a monday substitute? I assume that the holiday itself (e.g. Año Nuevo or Epifanía del Señor) is celebrated on given day and the Lunes siguiente a ...-monday is just personal leisure. If yes, I would put both into the holiday data.

As you describe, the day is fixed and next Monday is a leisure day. The big difficulty is that regions can opt in and out of this depending on how many holidays had this region already on non sundays. There is a maximum number of 14 days (as I recall) counting national and regional holidays.

I would be happy to hear that you are still on board here, otherwise I would take over from here.

Still onboard, bit busy and I already had some "leisure Mondays".

lauft commented 3 years ago

@vice Thanks for the update, I will take a look at it as soon as I can. 🤞🏻