Update locale hr-HR

[lauft]

This PR updates the holidays for Croatia according to the legal documents found here.

@gour There are some issues related to your PR which I cannot resolve as a non-native speaker. Maybe you can help me out?

Bogojav­lja­nje ili Sveta tri kra­lja

Holidata only supports one name for a holiday, so usually the most common used if the legal documents do not define it exactly. The testfiles had used Bogojav­ljenje (the legal documents use both), but is this the most used name? According to Wikipedia, Sveta tri kralja refers to the mythical figures, but not to the holiday itself... Btw.: the legal documents use the term Bogojav­lja­nje, while Wikipedia redirects to Bogojav­ljenje when searching for it. Is this a typo in the legal documents/alternative spelling/...?

Svi sveti

The legal documents use the notation Svi sveti (as does Wikipedia), you refer to it as Dan svih svetih. As far as I know Dan means Day of, so this would be the decision between All Saints' and All Saints' Day. I would assume Wikipedia uses the common notation, so I would go for that. What about the h at the end of svetih?

Uskrsni ponedjeljak

In all legal documents I see it written as Uskrsni ponedjeljak but you wrote it as Uskršni ponedjeljak. Is there a difference/this a typo in the legal documents/...?

[tbabej]

With respect to the 6th of January - my country of origin has this holiday as well - it basically is one religious holiday that has dual meaning, hence it is referred to by both names. This Wikipedia page should offer more detail: https://en.wikipedia.org/wiki/Epiphany_(holiday)

[gour]

Bogojav­lja­nje ili Sveta tri kra­lja

Holidata only supports one name for a holiday, so usually the most common used if the legal documents do not define it exactly. The testfiles had used Bogojav­ljenje (the legal documents use both), but is this the most used name? According to Wikipedia, Sveta tri kralja refers to the mythical figures, but not to the holiday itself... Btw.: the legal documents use the term Bogojav­lja­nje, while Wikipedia redirects to Bogojav­ljenje when searching for it. Is this a typo in the legal documents/alternative spelling/...?

Here is the official law document which states: : Bogojav­lja­nje ili Sveta tri kra­lja

Svi sveti

Same as above.

Uskrsni ponedjeljak

In all legal documents I see it written as Uskrsni ponedjeljak but you wrote it as Uskršni ponedjeljak. Is there a difference/this a typo in the legal documents/...?

Well, both forms can be used according the the grammar rules, but you can leave it as Uskrsni ponedjeljak.

Sincerely, Gour

[lauft]

The holiday's background was clear to me, the question was which notation holidata should use. As said, the legal documents do not define it – and I don't want to have "FOO or BAR" as its description.

We should try to keep holidata consistent such that it can always reproduce the past and present holiday data (at least since 2011). So consider that renaming a holiday has an effect on past data (and should kept rare). An official rename of a holiday is a different thing and it is handled by holidata via dedicated functions (see e.g. "Dan pobjede")

[tbabej]

The holiday's background was clear to me, the question was which notation holidata should use. As said, the legal documents do not define it – and I don't want to have "FOO or BAR" as its description.

Well, we might not like it, but I'd say if the official documents (what @gour linked is literally the law defining the holidays) use the form with "or", then that is the official name?

There is already a precedent for this in the holidata repository anyway, the sk-SK locale defines the 6th of January as:

sk-SK.py:    01-06: [NRF] Zjavenie Pána / Traja králi

which is the literal "or" form using the / character and is in accordance with the official list of the holidays on the government's list.

We should try to keep holidata consistent such that it can always reproduce the past and present holiday data (at least since 2011). So consider that renaming a holiday has an effect on past data (and should kept rare).

I agree 100% with this, but I would argue this is not renaming the holiday per se, but changing the name in the holidata db so that it is more inclusive with respect to the meanings of the holiday ascribed by different religious subgroups. Culturally, both names were always used, we merely made an arbitrary choice in the hr_HR locale previously to prefer one over the other.

[lauft]

This is the reason why I ask what the prevalent notation/usage is. As a non-native, not living there, I can only ask. 😁

If there are several possibilities I would like holidata to pick one and stick to it and not alternating between them every now and then.

Handling alternative spellings is a different stories. I have ideas for it, but for now we have to stick with this.

[lauft]

Redacted because of #97. If necessary, a new PR will be opened.