Add locale sl-SI - Githubissues

GothenburgBitFactory / holidata

Holidata is the core of holidata.net, a no-nonsense, ad-free provider of international holiday data.

https://holidata.net

MIT License

47 stars 13 forks source link

Add locale sl-SI #78

Closed lauft closed 2 years ago

lauft commented 2 years ago

Add the locale sl-SI to holidata.

Before merging, the following has to be resolved:

[x] Add official sources from the Government Gazette of the Republic of Slovenia for the holidays
[x] Confirm correctness of the holiday names
[x] Confirm that both, 01-01 and 01-02, are called novo leto (New Year's Day)
[x] Confirm that all holidays exept 01-02 have not changed since 2011

Closes #77

dejande commented 2 years ago

Confirm that both, 01-01 and 01-02, are called novo leto (New Year's Day)

They are

Confirm that all holidays exept 01-02 have not changed since 2011

01-02 was removed in 2012 and than added back in in 2016 (work-free holiday)
10-25 "dan suverenosti" was added in 2015 (non work-free holiday)
09-23 "dan slovenskega športa" was added in 2020 (non work-free holiday)

dejande commented 2 years ago

Add official sources from the Government Gazette of the Republic of Slovenia for the holidays

Answered in: https://github.com/GothenburgBitFactory/holidata/issues/77

lauft commented 2 years ago

@dejande I have updated the PR according to your feedback. I took the liberty to uniformly capitalize the first letter of each holiday name.

To me everything looks fine now, so I am going to prepare to create and release the data on holidata.net

lauft commented 2 years ago

Rebased and merged! Thanks for your contribution, @dejande. Please report back if there are any changes to the holidays, so we can keep this locale up to date. ❤️