Closed lauft closed 2 years ago
Yes the holiday itself doesn't shift so I guess the best approach would be that it uses the same name.
I will implement it then such that it has the same name, but with a note "Supplement".
Or is there a better term? 🤔
@girtu How is the rule for supplemental holidays handled for 12-25 Christmas Day
? If it is a sunday, then - by that rule - the following monday shall be a holiday. However, 12-26
is already a holiday (Day of Goodwill
). So is the supplemental holiday then forfeit or shifted further to 12-27
?
Hi - that is correct. In that situation the 27/12 would not be a holiday.
On 09 Mar 2022, at 09:27, Thomas Lauf @.***> wrote:
@girtu How is the rule for supplemental holidays handled for 12-25 Christmas Day? If it is a sunday, then - by that rule - the following monday shall be a holiday. However, 12-26 is already a holiday (Day of Goodwill). So is the supplemental holiday then forfeit or shifted further to 12-27?
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.
@girtu Rebased and merged. Thanks for your contribution! ❤️
Hope you can give a heads-up in case there are changes to the holiday laws in the future.
This adds the locale
en-ZA
(South Africa) according to the Public Holidays Act (Act No 36 of 1994).Before merging, the following has to be resolved:
By definition 2.1, whenever any public holiday falls on a Sunday, the following Monday shall be a public holiday. How is such a holiday then referred to? With the same name as the actual holiday? I take that the holiday itself is not shifted.