search

GothenburgBitFactory / tasklib

A Python library for interacting with taskwarrior databases.
http://tasklib.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
147 stars 28 forks source link

`task.waiting` is broken with new updates #104

Closed williamjameshandley closed 3 years ago

williamjameshandley commented 3 years ago

The task.waiting functionality is now broken, always returning false. I suspect this is due to the upcoming deprecation.

However, at the moment this is causing an error in the performance of taskwiki in that now the [W] tag never appears, and saving files will therefore unwait tasks which previously were waiting, which is causing quite a lot of problems with my task planning.

This can be fixed either at the taskwiki or tasklib side by replacing the task.waiting attribute with one that tests if task['wait'] is not None, rather than task['status']==WAITING. @tbabej is probably the best person to comment on where/how this should be fixed.

tbabej commented 3 years ago

Great report! This should be now fixed with #105, I will release 2.4.3 to ship this fix out.

williamjameshandley commented 3 years ago

cracking work! I can confirm that fixes the wait functionality in taskwiki. Many thanks.

tbabej commented 3 years ago

Amazing! Thanks for checking :slightly_smiling_face: