Number of improvements - Githubissues

GothenburgBitFactory / tasklib

A Python library for interacting with taskwarrior databases.

http://tasklib.readthedocs.org/en/latest/

BSD 3-Clause "New" or "Revised" License

147 stars 28 forks source link

Number of improvements #11

Closed tbabej closed 9 years ago

tbabej commented 9 years ago

Couple of improvements and fixes for the Task object:

done and delete operations should not be executed on tasks with invalid states
uuids should be used instead of ids, since ids are not unique across all tasks
added NotSaved, TaskCompleted and TaskDeleted exceptions, which are raised when operation failed due to these reasons
makes Task(tw, desc="random task").save() working
covers the functionality with tests
adds detection for Taskwarrior to the TaskWarrior object (and uses it for workaround)

tbabej commented 9 years ago

I found another while during the christmas break, now the pull request works over all supported versions of Python and Taskwarrior. Please review!

robgolding commented 9 years ago

This is awesome @tbabej, thanks for all the improvements. Can I ask what you're using the library for (assuming you're coming up against issues whilst implementing something?) Really appreciate you taking the time to contribute back :)

robgolding commented 9 years ago

New version released!

tbabej commented 9 years ago

Yes, I am porting the vimwiki-tasks (https://github.com/teranex/vimwiki-tasks) vim plugin from vimscript to python, and using tasklib as a abstraction layer between task and plugin makes the job easier :)

tbabej commented 9 years ago

Thanks for the review and enjoy the rest of the holidays!