Handle non-iterable (NoneType) comparison in LazyUUIDTaskSet

GothenburgBitFactory / tasklib

A Python library for interacting with taskwarrior databases.

http://tasklib.readthedocs.org/en/latest/

BSD 3-Clause "New" or "Revised" License

146 stars 27 forks source link

Handle non-iterable (NoneType) comparison in LazyUUIDTaskSet #65

Closed huntrar closed 5 years ago

huntrar commented 5 years ago

Fixes #64

coveralls commented 5 years ago

Coverage increased (+0.6%) to 92.347% when pulling dcf2b8b93cbfc94a86b64d03c0c154a6db671b44 on huntrar:develop into 922cec4a15255e90f69356886de250de034372d1 on robgolding:develop.

coveralls commented 5 years ago

Coverage increased (+0.6%) to 92.347% when pulling dcf2b8b93cbfc94a86b64d03c0c154a6db671b44 on huntrar:develop into 922cec4a15255e90f69356886de250de034372d1 on robgolding:develop.

coveralls commented 5 years ago

Coverage increased (+0.6%) to 92.347% when pulling dcf2b8b93cbfc94a86b64d03c0c154a6db671b44 on huntrar:develop into 922cec4a15255e90f69356886de250de034372d1 on robgolding:develop.

coveralls commented 5 years ago

Coverage increased (+0.6%) to 92.347% when pulling 811b104aac436b3603910d9ec8a6f3aa018f1e56 on huntrar:develop into 922cec4a15255e90f69356886de250de034372d1 on robgolding:develop.

robgolding commented 5 years ago

Hey @huntrar thanks so much for this! Could you maybe add a test to assert this behaviour? I'd be happy to merge and release a patch version after that 😄

Thanks again

huntrar commented 5 years ago

Absolutely. I added a handful of tests that use LazyUUIDTaskSet in place of a set() object pertaining to the depends field.

The test which actually catches the case listed in the issue is test_simple_dependency_lazyuuidtaskset_save_before_repeatedly

robgolding commented 5 years ago

Fantastic, thanks @huntrar!