search

GothenburgBitFactory / taskserver

Taskserver - Taskwarrior Synchronisation Server
Other
214 stars 38 forks source link

[TD-112] warning: missing initializer for member #112

Closed taskwarrior closed 6 years ago

taskwarrior commented 6 years ago

Dirk Deimeke on 2016-02-15T05:33:20Z says:

I am getting a couple of warnings when trying to build 1.2.0

{code:title=make|borderStyle=solid} Scanning dependencies of target taskd_executable [ 7%] Building CXX object src/CMakeFiles/taskd_executable.dir/taskd.cpp.o [ 7%] Building CXX object src/CMakeFiles/taskd_executable.dir/admin.cpp.o [ 15%] Building CXX object src/CMakeFiles/taskd_executable.dir/api.cpp.o [ 15%] Building CXX object src/CMakeFiles/taskd_executable.dir/client.cpp.o [ 15%] [ 23%] Building CXX object src/CMakeFiles/taskd_executable.dir/Color.cpp.o Building CXX object src/CMakeFiles/taskd_executable.dir/ConfigFile.cpp.o [ 23%] Building CXX object src/CMakeFiles/taskd_executable.dir/config.cpp.o [ 30%] Building CXX object src/CMakeFiles/taskd_executable.dir/daemon.cpp.o /home/dirk/workspace/taskd.git/src/ConfigFile.cpp: In copy constructor ‘Config::Config(const Config&)’: /home/dirk/workspace/taskd.git/src/ConfigFile.cpp:51:1: warning: base class ‘class std::map<std::basic_string, std::basic_string >’ should be explicitly initialized in the copy constructor [-Wextra] Config::Config (const Config& other) ^ [ 30%] Building CXX object src/CMakeFiles/taskd_executable.dir/diag.cpp.o [ 30%] Building CXX object src/CMakeFiles/taskd_executable.dir/Database.cpp.o [ 38%] Building CXX object src/CMakeFiles/taskd_executable.dir/FS.cpp.o /home/dirk/workspace/taskd.git/src/FS.cpp: In member function ‘bool Path::is_directory() const’: /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_dev’ [-Wmissing-field-initializers] struct stat s {}; ^ /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_ino’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_nlink’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_mode’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_uid’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_gid’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::pad0’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_rdev’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_size’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_blksize’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_blocks’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_atim’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_mtim’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::st_ctim’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:171:18: warning: missing initializer for member ‘stat::__unused’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp: In member function ‘bool Path::is_link() const’: /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_dev’ [-Wmissing-field-initializers] struct stat s {}; ^ /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_ino’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_nlink’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_mode’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_uid’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_gid’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::pad0’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_rdev’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_size’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_blksize’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_blocks’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_atim’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_mtim’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::st_ctim’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/FS.cpp:191:18: warning: missing initializer for member ‘stat::__unused’ [-Wmissing-field-initializers] [ 38%] Building CXX object src/CMakeFiles/taskd_executable.dir/help.cpp.o [ 46%] Building CXX object src/CMakeFiles/taskd_executable.dir/init.cpp.o [ 46%] Building CXX object src/CMakeFiles/taskd_executable.dir/ISO8601.cpp.o [ 53%] Building CXX object src/CMakeFiles/taskd_executable.dir/JSON.cpp.o [ 53%] Building CXX object src/CMakeFiles/taskd_executable.dir/Lexer.cpp.o /home/dirk/workspace/taskd.git/src/ISO8601.cpp: In constructor ‘ISO8601d::ISO8601d(int, int, int)’: /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_sec’ [-Wmissing-field-initializers] struct tm t {}; ^ /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_min’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_hour’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_mday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_mon’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_year’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_wday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_yday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_isdst’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_gmtoff’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:150:16: warning: missing initializer for member ‘tm::tm_zone’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp: In constructor ‘ISO8601d::ISO8601d(int, int, int, int, int, int)’: /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_sec’ [-Wmissing-field-initializers] struct tm t {}; ^ /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_min’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_hour’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_mday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_mon’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_year’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_wday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_yday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_isdst’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_gmtoff’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:166:16: warning: missing initializer for member ‘tm::tm_zone’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp: At global scope: /home/dirk/workspace/taskd.git/src/ISO8601.cpp:617:6: warning: unused parameter ‘n’ [-Wunused-parameter] bool ISO8601d::parse_named (Nibbler& n) ^ /home/dirk/workspace/taskd.git/src/ISO8601.cpp: In member function ‘bool ISO8601d::parse_date_time_ext(Nibbler&)’: /home/dirk/workspace/taskd.git/src/ISO8601.cpp:706:9: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] ; ^ /home/dirk/workspace/taskd.git/src/ISO8601.cpp: In member function ‘void ISO8601d::resolve()’: /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_sec’ [-Wmissing-field-initializers] struct tm t {}; ^ /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_min’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_hour’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_mday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_mon’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_year’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_wday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_yday’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_isdst’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_gmtoff’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/ISO8601.cpp:998:16: warning: missing initializer for member ‘tm::tm_zone’ [-Wmissing-field-initializers] [ 53%] Building CXX object src/CMakeFiles/taskd_executable.dir/Log.cpp.o [ 61%] Building CXX object src/CMakeFiles/taskd_executable.dir/Msg.cpp.o [ 61%] Building CXX object src/CMakeFiles/taskd_executable.dir/Nibbler.cpp.o [ 69%] Building CXX object src/CMakeFiles/taskd_executable.dir/RX.cpp.o [ 69%] Building CXX object src/CMakeFiles/taskd_executable.dir/Server.cpp.o [ 69%] Building CXX object src/CMakeFiles/taskd_executable.dir/status.cpp.o [ 76%] Building CXX object src/CMakeFiles/taskd_executable.dir/Task.cpp.o [ 76%] Building CXX object src/CMakeFiles/taskd_executable.dir/text.cpp.o [ 84%] Building CXX object src/CMakeFiles/taskd_executable.dir/Timer.cpp.o /home/dirk/workspace/taskd.git/src/Task.cpp:1405:6: warning: unused parameter ‘applyDefault’ [-Wunused-parameter] void Task::validate (bool applyDefault / = true /) ^ /home/dirk/workspace/taskd.git/src/Task.cpp:1552:6: warning: unused parameter ‘left’ [-Wunused-parameter] void Task::validate_before (const std::string& left, const std::string& right) ^ /home/dirk/workspace/taskd.git/src/Task.cpp:1552:6: warning: unused parameter ‘right’ [-Wunused-parameter] [ 84%] Building CXX object src/CMakeFiles/taskd_executable.dir/TLSClient.cpp.o [ 92%] Building CXX object src/CMakeFiles/taskd_executable.dir/TLSServer.cpp.o [ 92%] Building CXX object src/CMakeFiles/taskd_executable.dir/utf8.cpp.o /home/dirk/workspace/taskd.git/src/TLSClient.cpp: In member function ‘void TLSClient::connect(const string&, const string&)’: /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_flags’ [-Wmissing-field-initializers] struct addrinfo hints {}; ^ /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_family’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_socktype’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_protocol’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_addrlen’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_addr’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_canonname’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSClient.cpp:205:26: warning: missing initializer for member ‘addrinfo::ai_next’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp: In member function ‘void TLSServer::bind(const string&, const string&, const string&)’: /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_flags’ [-Wmissing-field-initializers] struct addrinfo hints {}; ^ /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_family’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_socktype’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_protocol’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_addrlen’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_addr’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_canonname’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:220:26: warning: missing initializer for member ‘addrinfo::ai_next’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp: In member function ‘void TLSTransaction::init(TLSServer&)’: /home/dirk/workspace/taskd.git/src/TLSServer.cpp:370:30: warning: missing initializer for member ‘sockaddr_in::sin_family’ [-Wmissing-field-initializers] struct sockaddr_in sa_cli {}; ^ /home/dirk/workspace/taskd.git/src/TLSServer.cpp:370:30: warning: missing initializer for member ‘sockaddr_in::sin_port’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:370:30: warning: missing initializer for member ‘sockaddr_in::sin_addr’ [-Wmissing-field-initializers] /home/dirk/workspace/taskd.git/src/TLSServer.cpp:370:30: warning: missing initializer for member ‘sockaddr_in::sin_zero’ [-Wmissing-field-initializers] [ 92%] Building CXX object src/CMakeFiles/taskd_executable.dir/util.cpp.o [100%] Building CXX object src/CMakeFiles/taskd_executable.dir/wcwidth6.cpp.o Linking CXX executable taskd [100%] Built target taskd_executable {code}

taskwarrior commented 6 years ago

Migrated metadata:

Created: 2016-02-15T05:33:20Z
Modified: 2016-10-30T16:24:33Z
taskwarrior commented 6 years ago

Paul Beckingham on 2016-10-30T16:24:33Z says:

This is resolved automatically with newer compilers that have full C++11 support.

For those that do not, it remains just a warning. I think the right thing to do is move on and bump the compiler version requirements, which are now raised to GCC 4.9 and Clang 3.4.