search

Gothic-Modding-Community / gmc

Gothic Modding Community github page
https://gothic-modding-community.github.io/gmc/
25 stars 15 forks source link

Update `scripts/index` and gothic sourcer article #135

Closed muczc1wek closed 3 weeks ago

kamilkrzyskow commented 3 months ago

The language server is AFAIK tool agnostic, it's not bound to VS Code, but the extension using the language server is. I also think if there are alternative tools to some aspects of Gothic Sourcer, then the article should have an opinionated comment about this, but I don't know about alternative 😆

muczc1wek commented 3 months ago

The language server is AFAIK tool agnostic, it's not bound to VS Code, but the extension using the language server is.

So how should I put this? I know dls != vscode-daedalus, but for the regular user these things are the same

kamilkrzyskow commented 3 months ago

Perhaps they're seen as the same, but docs should strive for factuality. Of course there are some opinionated takes here or there, but there should be a good reason for those.

Here instead of "Also known as Daedalus Language Server", for example change it to "The VS Code extension acts as a proxy for the Daedalus Language Server to provide [list of features]" or "The VS Code extension provides [list of features] and uses Daedalus Language Server as the back-end for them." etc. maybe ChatGPT has something better.

kamilkrzyskow commented 3 weeks ago

LGTM, nice work on the preservation of the Gothic Sourcer in a separate repository 👍 You can squash merge when you want :v: