Gothic-UnZENity-Project / Gothic-UnZENity

Fan project recreating Piranha Bytes' evergreens Gothic I and Gothic II in Unity Engine. Currently focussing on VR.
GNU General Public License v3.0
6 stars 1 forks source link

Feature/27 coding standards #38

Closed JaXt0r closed 2 weeks ago

JaXt0r commented 3 weeks ago

Please review briefly:


Out-of-scope:

ThomasMountainborn commented 3 weeks ago

protected bool isTest2; <-- Needs to be PascalCase like every non-private field

Hmm, I find that a bit weird, since then you still can't immediately tell the difference between a local variable and a member. The difference between private and protected isn't very relevant in the code, but the difference between local and member is. I find it clearest this way:

PublicMember _privateMember localVariable

JaXt0r commented 3 weeks ago

protected bool isTest2; <-- Needs to be PascalCase like every non-private field

Hmm, I find that a bit weird, since then you still can't immediately tell the difference between a local variable and a member. The difference between private and protected isn't very relevant in the code, but the difference between local and member is. I find it clearest this way:

PublicMember _privateMember localVariable

Yep. 100%. I didn't phrase it properly. But meant the same outcome as you said:

public PascalCase; protected PascalCase; private _underscoreCase; Local: camelCase;