search

Gothic-UnZENity-Project / Gothic-UnZENity

Fan project recreating Piranha Bytes' evergreens Gothic I and Gothic II in Unity Engine. Currently focussing on VR.
GNU General Public License v3.0
6 stars 1 forks source link

Feature/load savegame - Items and player location #55

Closed JaXt0r closed 1 week ago

JaXt0r commented 2 weeks ago

Please test now, but merge only after https://github.com/Gothic-UnZENity-Project/Gothic-UnZENity/pull/39

I implemented loading of a SaveGame. We can now load original G1 save games.

To Test:

  1. Play G1 where you removed an item and put an item to another location.
  2. Save the game.
  3. Open Gothic-UnZENity and seek the "Load Save Game" button on main menu
  4. Select the element
  5. Check if your spawning spot is correct.
  6. Check if the item changes on your game are the same like when you saved it in G1
  7. Please also traverse
    1. into the Old Mine and see if it loads (there was a crash before, when the world wasn't in the save game. Should work now.)
    2. Back into main world. Did you spawn where you expect to be after coming back?

Out-of-scope:

Tyroonis commented 1 week ago

@JaXt0r Where do I have to put the savegame?

Tyroonis commented 1 week ago

Looks good.

One Hint: I put down a stack of 3 beers in the original. In VR it is only 1

Here the Savegame: savegame2.zip

JaXt0r commented 1 week ago

@Tyroonis I see your point now: You put 3x beer onto the floor but when you pick it up in VR, you have only 1 item in you hand. For this PR, it's no issue, because we still hold the mesh in our hands. Once we have an inventory, we need to store, that we have 3x beer instead of one. We are already discussing with Luis about it (might be a missing amount variable) and will add it later.

If the loading is fine for you and also world switching worked, then please give it an approved.

JaXt0r commented 1 week ago

Thanks ticket is created: https://github.com/Gothic-UnZENity-Project/Gothic-UnZENity/issues/59

JaXt0r commented 1 week ago

Merge conflicts I need to resolve: