Gothic-UnZENity-Project / Gothic-UnZENity

Fan project recreating Gothic I and Gothic II in Unity Engine. Currently focussing on VR.
GNU General Public License v3.0
8 stars 2 forks source link

Feature/64 add conditional showhide of inspector properties #65

Closed JaXt0r closed 3 months ago

JaXt0r commented 3 months ago

I rearranged the lables and groupings of GameConfiguration. image

I also added a community package which provided features like Separator, Groups, and LabelOverrides. https://github.com/Deadcows/MyBox
It has 1.9k GitHub stars and is recommended within Unity Forums multiple times. It mostly contains Editor code #ifdef UNITY_EDITOR and therefore won't affect our production builds.

To Test:

Hint: With the default value changes, I changed the default Controls from XRIT to HVR. I added a troubleshooting note inside Developer documentation as well: https://github.com/Gothic-UnZENity-Project/Gothic-UnZENity/wiki/Developer's-Guide

JaXt0r commented 3 months ago

@lmichaelis feel free to check as well before we merge. No rush.

lmichaelis commented 3 months ago

Why are we using regions again? Style Guide specifically says not to. Otherweise looks nice :)

JaXt0r commented 3 months ago

Right 😅. The GameConfiguration is quite big, but I don't want to split it into multiple files these days. The regions follow the same logic as the Foldable elements in the UI. Better readability. But I can change this to a 3-line comment if needed.