GothicKit / ZenKit

A re-implementation of file formats used by the early 2000's ZenGin
http://zk.gothickit.dev/
MIT License
44 stars 10 forks source link

[v2.0.0] Switch to in-house MDS parser #14

Closed lmichaelis closed 1 year ago

lmichaelis commented 1 year ago

phoenix currently uses lexy for parsing model script files. This is only a temporary solution and should be replaced by a self-built parser which can properly take into account the broken scripts originally written by the team at PiranhaBytes (missing parentheses and such; see b317ad).

lmichaelis commented 1 year ago

Hey @thokkat and @Try, could you double check this new MDS parser on your end? Since you opened #50/#51, you might have some additional insight into this that I don't have. It would be greatly appreciated :>

You can find the new implementation in feature/mds-parser.

Try commented 1 year ago

Source code look good to me - will do more formal testing new week

Try commented 1 year ago

Tested today on G1, G2 - no issues spotted

lmichaelis commented 1 year ago

Thanks for the help, @Try :) I'll clean up the code and soon we'll be lexy-free :)