Closed Try closed 1 year ago
Partial duplicate of #21, but a good point. Until I can figure out a C++17 compatible way of using string-views all the way down, this is probably a good solution; especially for case-insensitive strings.
Since I've been able to implement most of these as std::string_view
I'm closing this issue. I have deprecated waynet::waypoint
since that API is broken anyways.
Current syntax:
symbol* script::find_symbol_by_name(const std::string& name)
forces client to bakestd::string
into interface. for find function this is especially unnecessary, since it does string copy immediatly after:In general it's probably would be good to pass read-only strings as
string_view
in all cases. If implementation then uses this string as key to has-map or similar - solve this locally inside the function.Other places: