[v1.1.0] Make `symbol::set_string` take a `std::string_view` instead of a `const std::string&`

GothicKit / ZenKit

A re-implementation of file formats used by the early 2000's ZenGin

http://zk.gothickit.dev/

MIT License

44 stars 10 forks source link

[v1.1.0] Make `symbol::set_string` take a `std::string_view` instead of a `const std::string&` #32

Closed lmichaelis closed 1 year ago

lmichaelis commented 1 year ago

This makes sense because the string is copied internally anyways. Additionally, defaulting to taking std::string_view provides more opportunities for copy elision. This is needed as a consequence to #30.