GothicKit / ZenKit

A re-implementation of file formats used by the early 2000's ZenGin
http://zk.gothickit.dev/
MIT License
44 stars 9 forks source link

Ubuntu build failures #40

Closed Try closed 1 year ago

Try commented 1 year ago

OpenGothic CI: https://ci.appveyor.com/project/Try/opengothic/builds/45436817/job/vljogctckhdu2sh0

https://github.com/lmichaelis/phoenix/blob/529137d516615d1a2e62fe380e5690f8cf078a7c/source/world/bsp_tree.cc#L60

[ 41%] Building CXX object lib/phoenix/CMakeFiles/phoenix.dir/source/world/bsp_tree.cc.o
/home/appveyor/projects/opengothic/lib/phoenix/source/world/bsp_tree.cc:60:3: error: extra ‘;’ [-Werror=pedantic]
   60 |  };
      |   ^
cc1plus: all warnings being treated as errors
make[3]: *** 
lmichaelis commented 1 year ago

I really gotta set up a pipeline with this compiler version, huh?

Try commented 1 year ago

from Appveyor logs:

-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
Try commented 1 year ago

Unfortunately not yet fixed: https://ci.appveyor.com/project/Try/opengothic/builds/45461180/job/x35as8pfmmvbo2og

In file included from /home/appveyor/projects/opengothic/lib/phoenix/source/ext/daedalus_classes.cc:3:
/home/appveyor/projects/opengothic/lib/phoenix/include/phoenix/ext/daedalus_classes.hh:135:16: error: extra ‘;’ [-Werror=pedantic]
  135 |  FLAG(npc_flag);
      |                ^
/home/appveyor/projects/opengothic/lib/phoenix/include/phoenix/ext/daedalus_classes.hh:262:18: error: extra ‘;’ [-Werror=pedantic]
  262 |  FLAG(item_flags);
      |                  ^
/home/appveyor/projects/opengothic/lib/phoenix/include/phoenix/ext/daedalus_classes.hh:1147:20: error: extra ‘;’ [-Werror=pedantic]
 1147 |  FLAG(c_menu_flags);
      |                    ^
/home/appveyor/projects/opengothic/lib/phoenix/include/phoenix/ext/daedalus_classes.hh:1200:25: error: extra ‘;’ [-Werror=pedantic]
 1200 |  FLAG(c_menu_item_flags);
      |                         ^
cc1plus: all warnings being treated as errors
make[3]: *** [lib/phoenix/CMakeFile
lmichaelis commented 1 year ago

Okay, I've finally set up GCC 9 in my pipeline starting at 0018655647dadf5bbd681340d6a4dff9b60d8cd1. No build errors for me.

Try commented 1 year ago

Yep, fixed. Thanks!