search

GothicVRProject / GothicVR

Fan project recreating the classic Gothic I and II experience in VR.
GNU General Public License v3.0
24 stars 2 forks source link

Feature/sky revamped #289

Closed JucanAndreiDaniel closed 5 months ago

JucanAndreiDaniel commented 5 months ago

To test

  1. Select random time and see if sky and fog color are properly set

Scene

Testing

JaXt0r commented 5 months ago

A few hints:

  1. Waterfalls are too bright and won'T be handled by the shadow. image

  2. Please create a FeatureFlag to enable/disable this fog feature. (I think we will have a performance setting in the future anyways. Therefore let's start with a feature flag.)

  3. Movement of clouds looks awesome.

JucanAndreiDaniel commented 5 months ago

A few hints:

1. Waterfalls are too bright and won'T be handled by the shadow.
   ![image](https://private-user-images.githubusercontent.com/120568393/296610976-e7190edb-e718-4d10-a3a4-3986a39f620d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDUyNTkwNTEsIm5iZiI6MTcwNTI1ODc1MSwicGF0aCI6Ii8xMjA1NjgzOTMvMjk2NjEwOTc2LWU3MTkwZWRiLWU3MTgtNGQxMC1hM2E0LTM5ODZhMzlmNjIwZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMTE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDExNFQxODU5MTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmFiZWFjYTlhYjhlNzI0MDljNmI3YmI1YTQ5MmE1MTkzZTgzODZkZWM5MmNhYjhlYTM5MDkyMmUwNWE2MjMzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._uNrdpID6wTdLuH7-b4Q9z8Lm0eYhNVGI6NOOdu5wcg)

2. Please create a FeatureFlag to enable/disable this fog feature. (I think we will have a performance setting in the future anyways. Therefore let's start with a feature flag.)

3. Movement of clouds looks awesome.

actually the waterfall relies on modifying the water shader to have fog applied, which i want to work a bit after i finish most of the barrier stuff