search

GotoLink / RecipeHandler

Minecraft Mod to handle conflicting recipes based on MinecraftForge API
6 stars 12 forks source link

Crash while 'Practice crafting' in Iblis environment #13

Closed Josral closed 6 years ago

Josral commented 6 years ago

I occasionally have a crash that has 'recipeitemhelper' mentioned in it a lot which I'm guessing is part of your mod. Iblis (https://minecraft.curseforge.com/projects/iblis?gameCategorySlug=mc-mods&projectID=272911) puts in a 'practice' environment for 'weaponsmithing' and 'armorsmithing'. The crash sometimes occurs when I do a lot of 'practice'. I submitted the crash issue on the Iblis page as well.

Thanks. crash-2018-02-21_12.35.40-client.txt

Josral commented 6 years ago

The author of the Iblis mod had this to say. "NoMoreRecipeConflict" mod calculate number of crafts for conflicting recipes in a GUI rendering phase. Since he doing it in parallel to Client tick thread results of such collision unpredictable. Obvious solution - delay such things to Client tick. Therefore I leave solution to GoTo, an author of "NoMoreRecipeConflict". Does that help?

GotoLink commented 6 years ago

This does help, except the iblis mod author is wrong. My GUI is done by the client tick thread. It is him that doesn't obey thread safety in his network. His problem code is here

Foghrye4 commented 6 years ago

Haha. GoTo catched me red-handed. Ok, I will move this from NetworkThread to scheduled tick.

Foghrye4 commented 6 years ago

Done. You may close issue.