GotoLink / RecipeHandler

Minecraft Mod to handle conflicting recipes based on MinecraftForge API
6 stars 12 forks source link

issues with NoMoreRecipeConflict and armorpus #15

Closed IchigoGames closed 6 years ago

IchigoGames commented 6 years ago

armorplus-1.12.2-11.11.1.37-beta

thedragonlib-1.12.2-5.2.0

MinecraftForge Version:2623

Minecraft 1.12.2

NoMoreRecipeConflict-0.10(1.12.2)

Client or Server?:

[y ] Client [ y] Server What happens / happened?: i was using the high tech workbench to craft some lava armor i saw that i could craft items from ImmersiveEngineering and immersivepetroleum as well as vanilla torch from nothing like nothing in the workbench but it lets me pull the item out tested with op and none op players with no change not sure if its this mod or one of the others allowing this to happen.

How can I reproduce it?: add the mods below with armorplus and click on the arrow key to see you can craft things from nothing click the small box with arrow and items pop out.

ImmersiveEngineering-0.12-80-core immersivepetroleum-1.12.2-1.1.8 NoMoreRecipeConflict-0.10(1.12.2) https://imgur.com/cCdpMBF

Morpheus1101 commented 6 years ago

This also occurs with Avaritia Extreme Crafting Table

GotoLink commented 6 years ago

The following recipes consider empty crafting space as valid if a subset of a bigger crafting table (9*9 for example):

See relevant .json files in assets/'modid'/recipes/ subfolders. Those are all using a factory as: "ingredient_shaped"="blusunrize.immersiveengineering.common.crafting.RecipeFactoryShapedIngredient" Which use a derived version of ShapedOreRecipe at: https://github.com/BluSunrize/ImmersiveEngineering/blob/master/src/main/java/blusunrize/immersiveengineering/common/crafting/RecipeShapedIngredient.java The error seems that the recipe is cutoff when trying to fit in bigger space. Issue has been reported to IE. https://github.com/BluSunrize/ImmersiveEngineering/issues/3027

GotoLink commented 6 years ago

BluSunrize fixed IE issue.