search

Gottox / sqsh-tools

🗜️ fast r/o squashfs implementation written in C.
https://gottox.de/sqsh-tools/
BSD 2-Clause "Simplified" License
37 stars 4 forks source link

sqsh_tree_walker_next2 was removed #149

Closed Dr-Emann closed 1 year ago

Dr-Emann commented 1 year ago

Describe the bug

Other sqsh_tree_walker functions were kept (but deprecated for their path resolver equivalents). Maybe this was intentional, I'm not sure if sqsh_tree_walker_next2 was considered "released" or not.

As an additional note, the deprecation messages for several sqsh_tree_walker functions refer to themselves as the function they were deprecated for (e.g. sqsh_tree_walker_type says: Since 1.2.0. Use sqsh_tree_walker_type() instead

Gottox commented 1 year ago

sqsh_tree_walker_next2 was never part of any release. The 1.1.x tree does not contain it, the 1.2.x tree is not yet released. So it's now part of the SqshPathResolver class as sqsh_path_resolver_next. SqshTreeWalker remains as thin shim around SqshPathResolver which provides backwards compatibility.

Gottox commented 1 year ago

As an additional note, the deprecation messages for several sqsh_tree_walker functions refer to themselves as the function they were deprecated for (e.g. sqsh_tree_walker_type says: Since 1.2.0. Use sqsh_tree_walker_type() instead

right. That's a c&p mistake.

Dr-Emann commented 1 year ago

Awesome, makes sense, thanks.