Gourieff / comfyui-reactor-node

Fast and Simple Face Swap Extension Node for ComfyUI
GNU General Public License v3.0
1.53k stars 148 forks source link

Fast FaceSwap indexing of multiple input faces unpredictable / out of order #443

Open BadXmpl opened 2 weeks ago

BadXmpl commented 2 weeks ago

First, confirm

What happened?

This prevents users from converting the input_face_index widget to an input in order to index the same face using SEGS or other detection nodes.

I spent a fair amount of time trying to figure out the detection order, but it seems unpredictable. These are the most common results I got. Expected index order = 0, 1, 2, 3 etc, left-to-right for faces of the same size and level).

Actual index orders:

Steps to reproduce the problem

2 workflows attached

  1. Indexing am image with 4 faces
  2. Aa comparison of how SEGS and the and the FaceCropper node index the same image.

FaceShaper 4 Faces Indexing.json FaceShaper Index Compare.json

Sysinfo

Mac Studio 24 core, 64 GB. MacOS 14.6.1. Safari, Chrome, Brave

Relevant console log

No errors.

Additional information

Adding a detection_order widget might fix this issue (I'm adding this as a feature request as well).

Gourieff commented 2 weeks ago

By default it counts faces from large to small but not from left to right (how it was in older versions) Just use it with Options Node изображение