Gourieff / sd-webui-reactor

Fast and Simple Face Swap Extension for StableDiffusion WebUI (A1111 SD WebUI, SD WebUI Forge, SD.Next, Cagliostro)
GNU Affero General Public License v3.0
2.46k stars 264 forks source link

[Feature]: lllyasviel/stable-diffusion-webui-forge gradio upgrade breaks face model selection menu #491

Open GlenCarpenter opened 1 month ago

GlenCarpenter commented 1 month ago

Feature description

Forge is now using the latest version of Gradio, which has deprecated the update method.

Would be great to restore this functionality.

This is a request to make sd-webui-reactor future-compatible with latest versions of Gradio,

GlenCarpenter commented 1 month ago

Context:

https://github.com/Gourieff/sd-webui-reactor/blob/613b7d74ea64cc76094661492c4e6b6af59f07d5/reactor_ui/reactor_main_ui.py#L28

https://github.com/lllyasviel/stable-diffusion-webui-forge/commit/e26abf87ecd1eefd9ab0a198eee56f9c643e4001

https://github.com/gradio-app/gradio/issues/6862#issuecomment-1866577714

GlenCarpenter commented 1 month ago

Current workaround for Forge is to use the a9e0c387008734e97b8ad7fa091d170cb7bd4fc5 commit, however this is not compatible with the new SD3 features

drdancm commented 1 month ago

I think I am reporting the very same problem:

After installation of new Forge version: f1.0.2v1.10.1-previous-40-g9cb69baf

Choosing Face Model fails to show Face models that are in the usual folder that used to work fine. In fact it also fails to work with a single Face Source.

InfiniteLoop-cmd commented 1 month ago

Same problem after updating

javascriptdotexe commented 1 month ago

Same problem here.

drdancm commented 1 month ago

I have not tried to add those same two line into the requirements.txt, but even if that works, I do not look forward to having to do it every time there is an update, and they come every couple of days.

Darknessssenkrad commented 1 month ago

I have not tried to add those same two line into the requirements.txt, but even if that works, I do not look forward to having to do it every time there is an update, and they come every couple of days.

is it just adding those lines that fix it? I can't seem to be able to select the radio button for the models option =(

drdancm commented 1 month ago

I tried the same fix, and it failed to work. I'm afraid I don't know which radio button you mean.

Darknessssenkrad commented 1 month ago

still not working not even with the fix provided in the requirements.txt